View Issue Details

IDProjectCategoryView StatusLast Update
0001961T99X171.00 SKB EagleSWpublic2025-04-07 10:17
Reporter(ALTech) JunGyu Kim Assigned To(SW) Kinbay Wu Due Date2024-10-11 17:12
PriorityurgentSeveritys4-minorReproducibilityN/A
Status closedResolutionreopened 
Summary0001961: [Smart3][ATV12] Implement VCOMPO_SetVideoSharpness / VCOMPO_GetVideoSharpness function
DescriptionHi Kinbay,

Recently, AML added function for control to sharpness and SKB wants implement function
Jira ticket : https://jira.skbroadband.com/browse/AMANDROIDS-185

This specification of function is already committed by SPTEK.
PATH : vendor/amlogic/btv-hal-impl/bfx-at100/hal_v_compo.cpp

@brief
sets Sharpness
**
@param[in] vcompo the video compositor handle
@param[in] sharpness sharpness value [0-100]
**
@retval 0 VCOMPO_SetVideoSharpness successfully.
@retval -1 error occurred or VCOMPO_SetVideoSharpness failed.
**
*/
int VCOMPO_SetVideoSharpness(VCOMPO_HANDLE vcompo, int sharpness);
 
/**
@brief
gets Sharpness value
**
@param[in] vcompo the video compositor handle
@param[out] sharpness sharpness value [0-100]
**
@retval 0 VCOMPO_GetVideoSharpness successfully.
@retval -1 error occurred or VCOMPO_GetVideoSharpness failed.
**
*/
int VCOMPO_GetVideoSharpness(VCOMPO_HANDLE vcompo, int *sharpness);

If you have any question, please let me know.
Thank you.
Kim
TagsNo tags attached.
Attach Tags

Users monitoring this issue

User List (ALTech) Jong-Hwa JUNG , (ALTech) Sangmin Choi , (ALTech) SY Yoon , (ALTech) Wooshin Kang , (ALTech) Younkwang Jung

Activities

(SW) Kinbay Wu

2024-06-13 17:15

developer   ~0016023

Hi Kim

What do I need to do for it?

Best Regards
Kinbay

(SW) Kinbay Wu

2024-06-13 17:42

developer   ~0016024

Hi Kim

Sorry, I will ask Kerwin to do it.

Best Regards
Kinbay

(ALTech) JunGyu Kim

2024-06-13 18:11

developer   ~0016025

Hi Kinbay,

BTF HAL API has been added.
Therefore, please create the contents of the function currently added by SPTEK.

As I know that similar code has been implemented in vendor/foxconn/prebuilts/lib/libhal_display.so, so I think you may refer to the contents of this library.

Thank you.
Kim

(ALTech) Younkwang Jung

2024-06-13 18:47

developer   ~0016026

Hi Kinbay

If this is implemented, please share the patch file and library file.
Please do not push to UI542 yet. SKB/ALT are planning to verify the function with SPTEK before lunch tomorrow.

I got a example guide from SoC and attached the picture file
And when you finally set up using the SoC's SetSharpness function, always set "is_enable" and "is_save" to 1.
int SetSharpness(int value, int is_enable, int is_save)
int GetSharpness()

I'm sorry for making urgent requests.

Please let me know if you have any questions.
Thank you
YK.Jung
image.png (409,424 bytes)

(SW) Kerwin Chen

2024-06-14 08:12

developer   ~0016028

Hi YK,

We will try to make the library ASAP this morning.
But we are not sure if it will be done before your lunch time.

Thanks.

(ALTech) Younkwang Jung

2024-06-14 08:31

developer   ~0016029

Hi Kerwin

Thank you for your support.

YK.Jung

(SW) Kinbay Wu

2024-06-14 10:52

developer   ~0016033

Last edited: 2024-06-14 10:55

Hi Jung, Kim

I built the libhal_display.so for the request as attached.
file replace path: .../vendor/foxconn/prebuilts/lib/libhal_display.so
And also attached the patch for it.
Patch path: vendor/amlogic/btv-hal-impl/bfx-at100

Please check it.
If any problem let me know, thanks.

Best Regards
Kinbay
Vcompo_VideoSharpness.diff (509 bytes)   
diff --git a/hal_v_compo.cpp b/hal_v_compo.cpp
index 71ef05f..214b12e 100644
--- a/hal_v_compo.cpp
+++ b/hal_v_compo.cpp
@@ -219,11 +219,13 @@ int  VCOMPO_SetVideoSharpness(VCOMPO_HANDLE vcompo, int sharpness) {
     
 	bool ret = false;
     ALOGD("++%s sharpness : 0x%x ", __FUNCTION__,  sharpness);
+    ret = HAL_VCOMPO_SetVideoSharpness(sharpness);
 
 	return ret;
 }
 
 int  VCOMPO_GetVideoSharpness(VCOMPO_HANDLE vcompo, int *sharpness) {
+    HAL_VCOMPO_GetVideoSharpness(sharpness);
 	return 0;
 }
 
Vcompo_VideoSharpness.diff (509 bytes)   
libhal_display.so (37,004 bytes)

(ALTech) Younkwang Jung

2024-06-14 11:34

developer   ~0016034

Hi Kerwin , Kinbay

Thank you , we will give you a feedback after checking

Thank you
YK.Jung

(ALTech) Younkwang Jung

2024-06-14 11:58

developer   ~0016035

Hi Kinbay

I think the header file( include/HAL_display.h ) should also be modified.
Please check it at your folder

And I built it with libhal_display.so , but the following error is being observed.
Please check it again

Thank you
YK.Jung
image-2.png (135,975 bytes)   
image-2.png (135,975 bytes)   

(ALTech) Younkwang Jung

2024-06-14 12:17

developer   ~0016036

Hi Kinbay

It is impossible to check your library because there is no symbol, but when I compare the size, it is less than before.
A function has been added, but it's strange to reduce the size.
Please check the library and patch file (include/HAL_display.h)

Thank you
YK.Jung
image-3.png (20,081 bytes)   
image-3.png (20,081 bytes)   

(SW) Kerwin Chen

2024-06-14 14:13

developer   ~0016037

Hi YK,

Kinbay is re-building the so file, please wait for the update.
Thanks.

(SW) Kinbay Wu

2024-06-14 14:26

developer   ~0016038

Hi Jung
 
Sorry for missing the patch.
And the libhal_display.so is I forgot to pull to the latest commit.
Please use the attached files to check it.

Best Regards
Kinbay
Vcompo_VideoSharpness_2.diff (955 bytes)   
diff --git a/hal_v_compo.cpp b/hal_v_compo.cpp
index 71ef05f..214b12e 100644
--- a/hal_v_compo.cpp
+++ b/hal_v_compo.cpp
@@ -219,11 +219,13 @@ int  VCOMPO_SetVideoSharpness(VCOMPO_HANDLE vcompo, int sharpness) {
     
 	bool ret = false;
     ALOGD("++%s sharpness : 0x%x ", __FUNCTION__,  sharpness);
+    ret = HAL_VCOMPO_SetVideoSharpness(sharpness);
 
 	return ret;
 }
 
 int  VCOMPO_GetVideoSharpness(VCOMPO_HANDLE vcompo, int *sharpness) {
+    HAL_VCOMPO_GetVideoSharpness(sharpness);
 	return 0;
 }
 
diff --git a/include/HAL_display.h b/include/HAL_display.h
index 7bfd2d5..f7d8f95 100644
--- a/include/HAL_display.h
+++ b/include/HAL_display.h
@@ -150,6 +150,10 @@ int HAL_VCOMPO_SetVideoSaturation(int saturation);
 
 int HAL_VCOMPO_GetVideoSaturation(int *saturation);
 
+int HAL_VCOMPO_SetVideoSharpness(int sharpness);
+
+int HAL_VCOMPO_GetVideoSharpness(int *sharpness);
+
 int HAL_DISPLAY_Create();
 
 int HAL_DISPLAY_Destroy();
libhal_display-2.so (37,888 bytes)

(ALTech) JunGyu Kim

2024-06-14 17:22

developer   ~0016040

Hi Kinbay,

We have tested your patch and libhal_display.so. It works well.
Please commit your patch to Sprint2 branch.

Thank you for support
Kim

(SW) Kinbay Wu

2024-06-14 17:32

developer   ~0016041

Hi Kim

I can't found any branch name Sprint2
Neither vendor/foxconn or vendor/amlogic/btv-hal-impl/bfx-at100

Best Regards
Kinbay

(ALTech) JunGyu Kim

2024-06-14 18:54

developer   ~0016044

Hi Kinbay,

You already committed as below branch and I check it.
vendor/foxconn ==> BFX-AT100_5.4.2
vendor/amlogic/btv-hal-impl/bfx-at100 ==> BTF_API_LEVEL_8/s905x2-Android12

Thank you for support.
Kim

(ALTech) JunGyu Kim

2024-06-18 12:29

developer   ~0016061

Hi Kinbay,

There will be a FW build today, but SKB has decided to build without this feature.
Therefore, please remove your uploaded commit.
I will request commit when applying again.

I'm sorry about inconvenience.

Thank you.
Kim

(SW) Kinbay Wu

2024-06-18 15:27

developer   ~0016062

Hi JG

The two patches were pushed back.
Please check it.

Best Regards
Kinbay

(ALTech) JunGyu Kim

2024-06-18 15:58

developer   ~0016063

Hi Kinbay,

I have just checked two patches were removed.
Thank you for support.

I will request again when need to apply it.
Thank you.
Kim

(ALTech) JunGyu Kim

2024-09-12 19:00

developer   ~0016704

Last edited: 2024-09-12 19:00

Hi Kinbay,

Please commit your sharpness patch to below branches
Smart 543 branch : BFX-AT100_5.4.3
UHD4 543 branch : BFX-UH200_5.4.3

Thank you.
Kim

(SW) Kinbay Wu

2024-09-13 09:32

developer   ~0016715

Hi JunGyu
 
I'm unable to fetch the branch named BFX-UH200_5.4.3.
Has the branch been pushed to the remote repository?
Or the branch on another remote URL?
 
BR,
Kinbay

(ALTech) JunGyu Kim

2024-09-13 10:40

developer   ~0016719

Hi Kinbay,

UHD4 has only ATV10 version.
So repository is different between Smart3 543 branch and UHD4 543 branch.

Smart ATV12 : ssh://git@bitbucket.skbroadband.com:7999/fstb-12/vendor-foxconn.git
UHD4 ATV 10 : ssh://git@bitbucket.skbroadband.com:7999/fstbq/vendor-foxconn.git

If you have any question, pleaes let me know.

Thank you.
Kim
image-4.png (182,336 bytes)   
image-4.png (182,336 bytes)   

(SW) Kinbay Wu

2024-09-13 11:17

developer   ~0016720

Hi JunGyu
 
I issue need modify two places.
(1) vendor/foxconn
(2) vendor/amlogic/btv-hal-impl/bfx-at100
For the UHD4 the (2) place still can't find the branch name BFX-UH200_5.4.3
 
Please help me to check it.
thanks
Kinbay

(ALTech) JunGyu Kim

2024-09-13 12:11

developer   ~0016721

Hi Kinbay,

Please commit (2) on BTF_API_LEVEL_8/s905x2 branch.

Thank you,
Kim
image-5.png (299,814 bytes)
image-6.png (462,650 bytes)

(SW) Kinbay Wu

2024-09-13 14:58

developer   ~0016722

Hi JunGyu
 
UHD4 pushed done.
Please check it.
 
BR,
Kinbay

(ALTech) JunGyu Kim

2024-09-19 13:24

developer   ~0016729

Hi Kinbay,

Thank you for support.
I close this ticket.

(ALTech) JunGyu Kim

2024-10-11 08:22

developer   ~0016827

Hi Kinbay,

SKB request that the shaprness patch should be NOT apply in UHD4.
So please revert the patch UHD4 543 branch.
I'm sorry for inconvenience.

Thank you.
Kim

(SW) Kinbay Wu

2024-10-14 15:39

developer   ~0016838

Hi JG

The two patches on 543 were pushed back.
Please check it.

Best Regards
Kinbay

(ALTech) JunGyu Kim

2024-10-14 16:39

developer   ~0016840

Thank you for support.
Close this issue.
Kim

(ALTech) JunGyu Kim

2025-01-07 13:06

developer   ~0017237

Hi Kinbay,

SKB decide today, the sharpness function will include in UI543 FW.
So, we have to apply the sparpness patch to UHD4 543 branch.

Before apply it, could you please share the diff file of libhal_display.so?

Thank you.
Kim

(SW) Kinbay Wu

2025-01-08 09:37

developer   ~0017239

Hi JunGyu

Attached is the rebuilt after revert revert the sharpness function patch
Please check it.

BR
Kinbay
0001-Revert-Revert-AMANDROIDS-185-MT-1961-Implement-VCOMP.patch (1,610 bytes)   
From 1d8563353cfdb6d9911698f1b347a06b671de2b5 Mon Sep 17 00:00:00 2001
From: Kinbay_Wu <kinbay.ty.wu@fii-foxconn.com>
Date: Wed, 8 Jan 2025 09:24:16 +0800
Subject: [PATCH] Revert "Revert "[AMANDROIDS-185] [MT-1961] Implement
 VCOMPO_SetVideoSharpness and VCOMPO_GetVideoSharpness function""

This reverts commit ef93186c94fedd16de4ae38e7600ff259d75365a.
---
 libbtvoemhal/bfxat100/hal_vcompo.cpp | 30 +++++++++++++++++++++++++++-
 1 file changed, 29 insertions(+), 1 deletion(-)

diff --git a/libbtvoemhal/bfxat100/hal_vcompo.cpp b/libbtvoemhal/bfxat100/hal_vcompo.cpp
index beee036..6527187 100644
--- a/libbtvoemhal/bfxat100/hal_vcompo.cpp
+++ b/libbtvoemhal/bfxat100/hal_vcompo.cpp
@@ -236,4 +236,32 @@ int HAL_VCOMPO_GetVideoSaturation(int *saturation)
 	}
 
 	return 0;
-}
\ No newline at end of file
+}
+
+int HAL_VCOMPO_SetVideoSharpness(int sharpness)
+{
+	bool ret = false;
+	HAL_LOGD("%s<%s> ..sharpness %d\n", LOG_TAG, __FUNCTION__, sharpness);
+	const sp<SystemControlClient> sws = getSystemControlService();
+
+	if (sws != nullptr) {
+		if(sws->setSharpness(sharpness, 1, 1) != -1)
+			ret = true;
+		HAL_LOGD("%s:%s v%d(SetVideoSharpness=%d)", LOG_TAG, __FUNCTION__, VERSION, sharpness);
+	}
+
+	return ret;
+}
+
+int HAL_VCOMPO_GetVideoSharpness(int *sharpness)
+{
+	HAL_LOGD("%s<%s> ..\n", LOG_TAG, __FUNCTION__);
+	const sp<SystemControlClient> sws = getSystemControlService();
+
+	if((sharpness != nullptr) && (sws != nullptr)) {
+		*sharpness = sws->getSharpness();
+		HAL_LOGD("%s:%s v%d(GetVideoSharpness=%d)", LOG_TAG, __FUNCTION__, VERSION, *sharpness);
+	}
+
+	return 0;
+}
-- 
2.25.1

libhal_display-3.so (54,696 bytes)

(SW) Kinbay Wu

2025-01-08 09:46

developer   ~0017240

Hi JunGyu

Sorry please ignore the last command attached so file.
Please use this one to test it.

BR,
Kinbay
libhal_display-4.so (54,696 bytes)

(SW) Kerwin Chen

2025-04-07 10:17

developer   ~0017451

no activity for this issue

Issue History

Date Modified Username Field Change
2024-06-13 16:31 (ALTech) JunGyu Kim New Issue
2024-06-13 16:31 (ALTech) JunGyu Kim Status new => assigned
2024-06-13 16:31 (ALTech) JunGyu Kim Assigned To => (SW) Kinbay Wu
2024-06-13 16:31 (ALTech) JunGyu Kim Issue Monitored: (ALTech) SY Yoon
2024-06-13 16:31 (ALTech) JunGyu Kim Issue Monitored: (ALTech) Younkwang Jung
2024-06-13 16:32 (ALTech) JunGyu Kim Issue Monitored: (ALTech) Jong-Hwa JUNG
2024-06-13 16:32 (ALTech) JunGyu Kim Issue Monitored: (ALTech) Sangmin Choi
2024-06-13 16:32 (ALTech) JunGyu Kim Issue Monitored: (ALTech) Wooshin Kang
2024-06-13 16:58 (ALTech) Younkwang Jung Priority normal => urgent
2024-06-13 17:15 (SW) Kinbay Wu Note Added: 0016023
2024-06-13 17:42 (SW) Kinbay Wu Note Added: 0016024
2024-06-13 18:11 (ALTech) JunGyu Kim Note Added: 0016025
2024-06-13 18:47 (ALTech) Younkwang Jung Note Added: 0016026
2024-06-13 18:47 (ALTech) Younkwang Jung File Added: image.png
2024-06-14 08:12 (SW) Kerwin Chen Note Added: 0016028
2024-06-14 08:31 (ALTech) Younkwang Jung Note Added: 0016029
2024-06-14 10:52 (SW) Kinbay Wu Note Added: 0016033
2024-06-14 10:52 (SW) Kinbay Wu File Added: Vcompo_VideoSharpness.diff
2024-06-14 10:52 (SW) Kinbay Wu File Added: libhal_display.so
2024-06-14 10:55 (SW) Kinbay Wu Note Edited: 0016033
2024-06-14 11:34 (ALTech) Younkwang Jung Note Added: 0016034
2024-06-14 11:58 (ALTech) Younkwang Jung Note Added: 0016035
2024-06-14 11:58 (ALTech) Younkwang Jung File Added: image-2.png
2024-06-14 12:17 (ALTech) Younkwang Jung Note Added: 0016036
2024-06-14 12:17 (ALTech) Younkwang Jung File Added: image-3.png
2024-06-14 14:13 (SW) Kerwin Chen Note Added: 0016037
2024-06-14 14:26 (SW) Kinbay Wu Note Added: 0016038
2024-06-14 14:26 (SW) Kinbay Wu File Added: Vcompo_VideoSharpness_2.diff
2024-06-14 14:26 (SW) Kinbay Wu File Added: libhal_display-2.so
2024-06-14 17:22 (ALTech) JunGyu Kim Note Added: 0016040
2024-06-14 17:32 (SW) Kinbay Wu Note Added: 0016041
2024-06-14 18:54 (ALTech) JunGyu Kim Note Added: 0016044
2024-06-18 12:29 (ALTech) JunGyu Kim Note Added: 0016061
2024-06-18 15:27 (SW) Kinbay Wu Note Added: 0016062
2024-06-18 15:58 (ALTech) JunGyu Kim Note Added: 0016063
2024-09-12 19:00 (ALTech) JunGyu Kim Note Added: 0016704
2024-09-12 19:00 (ALTech) JunGyu Kim Note Edited: 0016704
2024-09-13 09:32 (SW) Kinbay Wu Note Added: 0016715
2024-09-13 10:40 (ALTech) JunGyu Kim Note Added: 0016719
2024-09-13 10:40 (ALTech) JunGyu Kim File Added: image-4.png
2024-09-13 11:17 (SW) Kinbay Wu Note Added: 0016720
2024-09-13 12:11 (ALTech) JunGyu Kim Note Added: 0016721
2024-09-13 12:11 (ALTech) JunGyu Kim File Added: image-5.png
2024-09-13 12:11 (ALTech) JunGyu Kim File Added: image-6.png
2024-09-13 14:58 (SW) Kinbay Wu Note Added: 0016722
2024-09-19 13:24 (ALTech) JunGyu Kim Status assigned => closed
2024-09-19 13:24 (ALTech) JunGyu Kim Resolution open => fixed
2024-09-19 13:24 (ALTech) JunGyu Kim Note Added: 0016729
2024-10-11 08:22 (ALTech) JunGyu Kim Status closed => feedback
2024-10-11 08:22 (ALTech) JunGyu Kim Resolution fixed => reopened
2024-10-11 08:22 (ALTech) JunGyu Kim Due Date 2024-06-14 17:12 => 2024-10-11 17:12
2024-10-11 08:22 (ALTech) JunGyu Kim Note Added: 0016827
2024-10-14 15:39 (SW) Kinbay Wu Note Added: 0016838
2024-10-14 16:39 (ALTech) JunGyu Kim Status feedback => closed
2024-10-14 16:39 (ALTech) JunGyu Kim Note Added: 0016840
2025-01-07 12:56 (ALTech) JunGyu Kim Status closed => feedback
2025-01-07 13:06 (ALTech) JunGyu Kim Status feedback => assigned
2025-01-07 13:06 (ALTech) JunGyu Kim Note Added: 0017237
2025-01-08 09:37 (SW) Kinbay Wu Note Added: 0017239
2025-01-08 09:37 (SW) Kinbay Wu File Added: 0001-Revert-Revert-AMANDROIDS-185-MT-1961-Implement-VCOMP.patch
2025-01-08 09:37 (SW) Kinbay Wu File Added: libhal_display-3.so
2025-01-08 09:46 (SW) Kinbay Wu Note Added: 0017240
2025-01-08 09:46 (SW) Kinbay Wu File Added: libhal_display-4.so
2025-04-07 10:17 (SW) Kerwin Chen Status assigned => closed
2025-04-07 10:17 (SW) Kerwin Chen Note Added: 0017451